Improve template specialisation selection (#1267) #1268
Merged
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
License check appears to have failed due to a network or transient error? |
|
I confirm this change is valid and fixes the issue indicated. |
A numeric or boolean template argument in a partial specialisation needs to be resolved, which isn't currently being handled.
jonahgraham
force-pushed
the
improve-partial-specialisation
branch
from
cafd51f to
0ebbd0e
Compare
|
@davmac314 Thank you for your contribution and @i-garrison thank you for reviewing it. I am merging this under the special review policy. As I am in the middle of handling many of these PRs at once, I have done the build and test of them all in #1356 and I am applying the changes back to this PR so that it is tracked properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A numeric or boolean template argument in a partial specialisation needs to be resolved, which isn't currently being handled.